Repository navigation
Conversation
Strokkur424
approved these changes
Sep 6, 2025
jpenilla
force-pushed
the
feat/command-feedback-helpers
branch
from
October 7, 2025 19:55
1f87762 to
e086eba
Compare
Member
Author
|
Revisiting this I'm not sure if sendToTarget is the best name for that method |
Strokkur424
reviewed
Oct 1, 2026
| * @param message the message to send | ||
| * @param allowInformingAdmins whether admins and console may be informed of this success | ||
| */ | ||
| void sendSuccess(ComponentLike message, boolean allowInformingAdmins); |
Member
There was a problem hiding this comment.
What about introducing an overload where the last parameter defaults to true? Or is the general consensus to not bring any unexpected surprises?
Member
Is there a problem with just mirroring Vanilla naming and calling it |
Member
|
Replaced with #14331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps plugin developers more easily follow vanilla conventions when their commands are used for example by
/executeor a datapack function.