Repository navigation
Fix equivalent Table projections and restore recursive array updates - #282
Merged
Merged
Conversation
19 of 35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid captured-value Table map followed by record construction could fail compilation because the record simplifier required identical MLIR types even when their hardware types were equivalent. Keep the verified aggregate projection when no exactly typed replacement exists. Genuine type mismatches, dominance checks, Bits provenance handling and dependency verification remain unchanged; no cast, API or backend path is added.
Restore the full historical
recursive_array_updatesexample using this existing source surface: nominal Struct/Enum values, Tables of 3/5/3/65 elements, five actual immutable updates, all fourteen result fields (42 bits), and the original two depth-one queues. Zero initialization plus shared maps replaces 65 repeated seed literals; the modulo-three index is reused. A compact@systemretains the original four cases.Validation:
Local ignored evidence:
docs/gates/logs/recursive-array-20261009/, with current stages infinal-stages-shared-index/. An initial system-test launch lacked native-tool environment variables; its failed setup log is retained separately from the successful full rerun.Root-specific four-state, exhaustive input-space, full-catalog/nightly and platform acceptance are not claimed. This closes one historical root; four remain in #272. Table-of-Table indexing and retired range/array APIs remain outside scope.