Repository navigation
Correct cooperative TMATMUL shape and packed Shared operand views - #383
Open
ckwllawliet wants to merge 7 commits into
Open
ckwllawliet wants to merge 7 commits into
ckwllawliet wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cooperative TMATMUL currently rejects otherwise legal non-power-of-two shapes and can apply Local scratch limits to real Shared inputs. This change corrects shape legality and private operand addressing for all six cooperative forms, including packed inputs, padding, transpose, large Shared sources and subviews.
Change contract
3eb214759679731685b2f83691329da534e17dd4.e145c45c674fdc41b0b71564abf0e0433a6be29b; reconciled PR base/merge base:f3fa24331df452248366550f71cd1be22e62aeb1.Changed NDF clauses:
Normative owners:
asl/block/attributes/B.FPATR.asl.asl/block/execution/BSTART.TMATMUL*.aslowners and sixasl/tile/matrix-and-matrix-vector/matrix-matrix/TMATMUL*.aslowners.asl/block/model/dispatch/{cube-tmatmul,matrix-scale,shared-cube-matrix}.asl.asl/tile/model/execution/{cube,matrix-scale}.aslandasl/tile/model/legality/{matrix-functions,matrix-shape}.asl.Normative delta
Compatibility: breaking for consumers of cooperative shape legality: more non-power-of-two shapes become legal, while odd K or odd physical pitch becomes illegal for packed Shared primaries. Consumers should update their legality checks and conformance cases. No separately tracked downstream repository PR is required for this V1 change; full release evidence remains a later obligation. The layout-census tooling explicitly classifies private-view relations and retains fail-closed mutation canaries.
Agent review
/root/issue374_executor./root/issue374_reviewer; complete independent implementation review, correction review and final exact-input gate review.review_complete=true, all eight mandatory areas complete, both consolidated findings closed, no unresolved findings. Receipt check:scripts/prepare-pr --base origin/main --head HEAD --review build/pr-review.jsonpasses withreview: reviewedfor the head above, tree0bf07b4b337e8c636277d32626fb346c48f5da65and diff SHA-2568c7fbef8bda279ab21024b5ac3b8d625032c98b798e8c91ac7a9a72adddac3cb. External execution record:issue-374__review-report-r7.md, SHA-256d38929f668e8808a3ba5f8c22332e424f06481033dd14499e22fb906a14296a7; local receipt SHA-2561fb602fe46e25634ddbb4f28016ecd014924ae120c31c67218d8628dda052cfd.Projections and focused evidence
5528ca05and 30 unchanged-input results from5cb029be. Subsequent changes only affect governance/projections; their reuse eligibility was independently checked. No claim of a single 32-point run at final HEAD.make pr-checkon final signed HEAD.git diff --check.Final signed HEAD passes
make pr-check(11/11 checks), site typecheck, site unit tests (14/14), and clean English/Chinese build. Focused migration tests pass 7/7; ADR checks cover 116 records. Site validation uses pinned pnpm 10.30.0. A bounded 8 GiB Node heap setting is used for the clean bilingual build after a preserved default-heap resource failure. No dependency manifest or lockfile is changed.make repo-checkis unnecessary because binary/encoding/operand/decoder identity is unchanged.Release boundary
Release impact and known gaps: cooperative legality is architecture-visible. Existing Issue #367 arithmetic/accumulator residuals remain outside this shape/addressing correction. No new arithmetic goldens or precision/rounding/NaN/scale-value behavior are introduced or verified by this task. This task publishes a ready PR only; it does not merge, close the issue, tag or release.