Repository navigation
fix(site): mitigate blocking high dependency advisories in the portal build - #368
Merged
Merged
Conversation
zhoubot
force-pushed
the
codex/site-security-overrides
branch
from
October 10, 2026 10:18
db4e510 to
d5a67e6
Compare
zhoubot
enabled auto-merge (squash)
October 10, 2026 10:18
zhoubot
added a commit
that referenced
this pull request
Oct 10, 2026
Canonical `THREAD_ID` at `0x0026` now reports the executing PE index 0–3, letting code launched at the common entry distinguish PE0 from workers. Previously every PE read zero. This implements the PE-identity decision for #150 on top of merged #373's independent PE contexts and common kernel entry. The value is derived from execution context rather than mutable saved register storage. The existing SYS-block placement, read-only permissions and unknown-address rejection remain enforced; `0x0802` stays unassigned. The change includes owning ASL, projected catalog/documentation, bilingual reader guides, the ADR-STATE-0008 amendment, and independent AVS. Normative owner: `asl/scalar/model/sys/semantics.asl`, clause `PTO-THREAD-ID-PE-IDENTITY-001`. Related owners: system-register data types/reset and PE execution context. Decision baseline: `e182c9b70d54a3a264bac54af9b915a0e43bb519`. Compatibility is **breaking** for software relying on zero on PE1–PE3; PE0 and all instruction encodings/access classes are unchanged. Release impact is required; no release or publication is claimed. Validation includes a four-PE regression that failed on the old implementation, then passed with the fix. Eight focused ASL points cover decoded SSRGET/HL.SSRGET at all ACRs, encoded write/swap rejection, retired-address and Standard-block rejection, actual interrupt recovery and fault retry, Core/PE selection, reset/relaunch, and affected existing reset/Shared-memory behavior. Bilingual guide semantics and translation were independently accepted by `/root/review_369` and verified by `/root/review_373` before attestation. LLVM/TileOP must emit canonical `THREAD_ID` in a legal SYS envelope; changing only the old address in a Standard Block is insufficient. Runtime startup must branch from the common entry before entering libc. Downstream compiler/runtime/model updates and regenerated ELF validation are still required. Refs #150. This PR deliberately does not close that integration issue: the complete hosted stack/TLS/libc/fd/exit/ELF ABI, runtime-only carrier, and same-ELF independent-golden gfrun/QEMU matmul acceptance remain unverified. Historical runtime passes and the previous separate-entry ABI do not validate this contract. Final independent exact-input review: `/root/review_369`, APPROVE, zero findings, compatibility **breaking**. Base `0d4464a03f761ed113078c750010f445300e7568`; head `db5239b82e9e1d73ccb64c86dbd6314cb43f0a5b`; tree `6c584118748c304ea8efe03465c258602a85e1cc`; diff SHA-256 `9f8b8cd3d91951c889f0ac285852681fe8ed66f3ed4e41a2d47362e214cd1383`. Receipt verified by `scripts/prepare-pr`; reviewer execution identities are not GitHub approvals. Final local evidence: `make pr-check` 11/11; `make repo-check` 7/7; focused ASL 8/8. These results are reused against the byte-identical semantic/documentation patch after rebasing on #368's two dependency files; 19 site-contract tests additionally passed on the updated base. All three commits are signed. Fresh hosted checks apply to the pushed head. Exact-commit full release validation remains outstanding. --------- Co-authored-by: zhoubot <637081+zhoubot@users.noreply.github.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin patched transitive versions of brace-expansion (1.1.20), fast-uri (3.1.7), and joi (17.13.7) in the portal package overrides and lockfile. This remediates the reported dependency advisories while preserving all existing overrides and security checks. The lockfile also carries the original dev-only third-party-web resolution update.
No ISA/NDF clause, architecture owner, ABI or release contract changes. Compatibility: compatible. Release impact and downstream runtime obligations: not applicable. This PR does not claim that unrelated portal artifact-size/browser-test failures or all future advisories are resolved.
Independent exact-input review:
/root/review_341_368, APPROVE, zero findings. Base5641479c212abb86d46ac9cf7ececf82ac9e1a73; signed headd5a67e66646529ea4f004c7d196070930e42625e; treeeae37ed541399783a33087e11db941d1c3a5c50b; diff SHA-2566553cd24950e3cb32722690052dc38ad3ec0dd1262c862f6cdc0f1ced193535b. Receipt validated byscripts/prepare-pr. The patch is byte-equivalent to the original reviewed two-file change (stable patch-idc17b868d39c3aef901f1fe7a1e6d2dd458a74d34).Validation on this candidate: site contract tests 19/19;
git diff --check; clean worktree. Original branch security audit/build results remain historical evidence, not a fresh audit claim. Required hosted checks must pass on this newly signed head before merge. No site publication or release is requested.