Repository navigation
Collapse prenatalppkt.ipynb to 2 comprehensive cells: Observer, ViewPoint - #112
Merged
VarenyaJ merged 1 commit intoJul 20, 2026
Conversation
…oint Replaces 5 overlapping demo blocks (Initial Demo, Basic Observer Process, Biometry to HPO and LOINC, ViewPoint HL7 to HPO and LOINC, Genomics Scaffold) with 2 cells that each cover every fixture and every angle in one pass instead of splitting them across cells with duplicated logic. Observer cell batches all 5 *_Sally_pretty.json fixtures through the real build_observer_phenopacket() builder, then for each fetus adds LOINC-coded measurements and dummy genomics scaffolding (VCF file + interpretation, reused across all cases since these are synthetic fixtures, not real per-patient data). ViewPoint cell does the same via build_viewpoint_phenopacket() across 5 HL7 fixtures: the 4 existing synthetic ones plus Discrete_HL7_Messages_Sample.txt (a GE ViewPoint vendor demo export with placeholder patient data we gitignored long ago)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*_Sally_pretty.jsonfixtures through the realbuild_observer_phenopacket()builder, then for each fetus adds LOINC-coded measurements and dummy genomics scaffolding (VCF file + interpretation, reused across all cases since these are synthetic fixtures, not real per-patient data).build_viewpoint_phenopacket()across 5 HL7 fixtures: the 4 existing synthetic ones plusDiscrete_HL7_Messages_Sample.txt(a GE ViewPoint vendor demo export with placeholder patient data that we had previously gitignored).