Skip to content

Collapse prenatalppkt.ipynb to 2 comprehensive cells: Observer, ViewPoint - #112

Merged
VarenyaJ merged 1 commit into
vj/fix-narrative-feature-negationfrom
vj/notebook-observer-viewpoint-cleanup
Jul 20, 2026
Merged

VarenyaJ merged 1 commit into
vj/fix-narrative-feature-negationfrom
vj/notebook-observer-viewpoint-cleanup

Conversation

@VarenyaJ

Copy link
Copy Markdown
Collaborator

Summary

  • Replaces 5 overlapping demo blocks (Initial Demo, Basic Observer Process, Biometry to HPO and LOINC, ViewPoint HL7 to HPO and LOINC, Genomics Scaffold) with 2 cells that each cover every fixture and every angle in one pass instead of splitting them across cells with duplicated logic.
  • Observer cell batches all 5 *_Sally_pretty.json fixtures through the real build_observer_phenopacket() builder, then for each fetus adds LOINC-coded measurements and dummy genomics scaffolding (VCF file + interpretation, reused across all cases since these are synthetic fixtures, not real per-patient data).
  • ViewPoint cell does the same via build_viewpoint_phenopacket() across 5 HL7 fixtures: the 4 existing synthetic ones plus Discrete_HL7_Messages_Sample.txt (a GE ViewPoint vendor demo export with placeholder patient data that we had previously gitignored).

…oint

Replaces 5 overlapping demo blocks (Initial Demo, Basic Observer
Process, Biometry to HPO and LOINC, ViewPoint HL7 to HPO and LOINC,
Genomics Scaffold) with 2 cells that each cover every fixture and
every angle in one pass instead of splitting them across cells with
duplicated logic.

Observer cell batches all 5 *_Sally_pretty.json fixtures through the
real build_observer_phenopacket() builder, then for each fetus adds
LOINC-coded measurements and dummy genomics scaffolding (VCF file +
interpretation, reused across all cases since these are synthetic
fixtures, not real per-patient data).

ViewPoint cell does the same via build_viewpoint_phenopacket() across
5 HL7 fixtures: the 4 existing synthetic ones plus
Discrete_HL7_Messages_Sample.txt (a GE ViewPoint vendor demo export
with placeholder patient data we gitignored long ago)
@VarenyaJ VarenyaJ added this to the prenatalseq refinements milestone Jul 17, 2026
@VarenyaJ VarenyaJ self-assigned this Jul 17, 2026
@VarenyaJ VarenyaJ added the enhancement New feature or request label Jul 17, 2026
@VarenyaJ
VarenyaJ marked this pull request as ready for review July 20, 2026 13:21
@VarenyaJ
VarenyaJ merged commit aa2cf58 into vj/fix-narrative-feature-negation Jul 20, 2026
3 checks passed
@VarenyaJ
VarenyaJ deleted the vj/notebook-observer-viewpoint-cleanup branch September 16, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant