Repository navigation
TODO scaffolding for cardiac echo parsing and known quirks (#93) - #110
Merged
Merged
Conversation
VarenyaJ
added
documentation
VarenyaJ
marked this pull request as ready for review
July 20, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
etl/sections/fetal_echo.pycardiac.*section inconcept_aliases.yamldocumenting the Observerfetal_echo_anatomy[]<-> ViewPointHeartFetus.*correspondence - documentation only, the parser itself stays a skeleton._resolve_subject_gain bothobserver_phenopacket.pyandviewpoint_phenopacket.py(adating.get("ga_weeks")dead-key quirk - that key is never actually returned by either pregnancy-dating parser),clinical_impression.py's_infer_growth_assessment(computed but never consumed by either builder), and a note on all builder files about now having 3x-duplicated private helpers worth revisiting.