Repository navigation
Move altitude from Feature property to Coordinate3D Z component - #2
Merged
Merged
Conversation
Altitude values are now stored as the 3rd element (Z) of each Coordinate3D in the MultiLineString geometry instead of being a parallel array in feature.properties["fit_altitudes"]. - decode: altitude embedded in Coordinate3D(z:) during buildSegments - encode: altitude read from coordinate.altitude via buildRecordMessage - fitAltitudes now reads from coordinate Z values - fitPointFeatures writes altitude to coordinate.altitude, not properties - fitTrackFromPointFeatures preserves altitude in coordinates - Added 4 altitude-specific tests verifying Z embedding and round-trips
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altitude values are now stored as the 3rd element (Z) of each Coordinate3D in the MultiLineString geometry instead of being a parallel array in feature.properties["fit_altitudes"].