-
Notifications
You must be signed in to change notification settings - Fork 5
Fix create
#134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0xisk
merged 11 commits into
OpenZeppelin:main
from
andrew-fleming:fix-create-improve-type-check
Jul 29, 2026
Merged
Fix create
#134
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
93e4674
fix create method
andrew-fleming 9d4281e
move emit to build.json, fold test sims into the types check
andrew-fleming ed07aec
revert typecheck refactor
andrew-fleming 3d5a189
Merge branch 'main' into fix-create-improve-type-check
0xisk 1740ef4
add _create type sibling
andrew-fleming d9fea4f
improve doc on overriding create
andrew-fleming 734256d
fix return doc in create
andrew-fleming ac8152b
add named alias (so it looks intentional)
andrew-fleming 636322f
add regression guard
andrew-fleming 3899581
Merge remote-tracking branch 'origin/fix-create-improve-type-check' i…
andrew-fleming b0293b4
Merge branch 'main' into fix-create-improve-type-check
andrew-fleming File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,4 +18,4 @@ | |
| "dist", | ||
| "tests" | ||
| ] | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.