You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there!
Thanks for adding phase-space scoring and WSL support. Before we can merge this, please address the following:
Update your branch with the latest changes from develop and resolve the conflicting files (input_handling and write_PCF).
The script currently fails to run because it cannot find wslPath. Please include this dependency or, better, replace it with built-in Python path handling tool.
Use the same capitalization for PhaseSpace everywhere. Some parts currently use PhaseSpace, while others use (lowercase) phasespace.
Please check the WSL file-copy command. Code running inside WSL normally uses cp, not the Windows copy command.
Selection of ROI based on numbers starts at 1 and expects a certain order (in ChooseROIs for ROI_List[i+1]), but this might not be a warranty in all DICOM RTSTRUCT files. You could loop through the elements instead.
Fix the ROI file-writing code. Some lines format the filename after writing the text, this could cause the program to crash.
Check that an input file has enough lines before reading values from it (e.g., before accessing inputInfo[9]). A short or incomplete file can currently cause an unexpected error.
Please avoid breaking existing input files. The new operating-system line makes the older format unusable. Add protection to continue supporting the old format, and add to the README how users must update their files.
Add tests for the new features in ./tests/, including phase-space scoring, multiple ROIs, WSL paths, incomplete input files, and older input files.
After updating the branch, please run:
python3 -m pytest -q
python3 -m py_compile *.py
Cheers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.