Skip to content

Shape Healing - Fix Standard_OutOfRange in connectWiresToWiresImpl on wire with internally-oriented edge #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidgilkaufman wants to merge 2 commits into
base: master
Choose a base branch
from
+29 −3
Open

Shape Healing - Fix Standard_OutOfRange in connectWiresToWiresImpl on wire with internally-oriented edge #1331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
349bf1e
Add failing test case for memory access out of bounds
davidgilkaufman Jul 8, 2026
7557161
Fix handling of wires with no manifold edges
davidgilkaufman Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ModelingAlgorithms/TKShHealing/ShapeAnalysis/ShapeAnalysis_FreeBounds.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,12 @@ static void connectWiresToWiresImpl(
{
if (!aSel.ContWire(i))
{
lwire = i;
sewd->Add(TopoDS::Wire(arrwires->Value(lwire)));
aSel.LoadList(lwire);
sewd->Add(TopoDS::Wire(arrwires->Value(i)));
aSel.LoadList(i);

if (sewd->NbEdges() > 0)
{
lwire = i;
break;
}
sewd->Clear();
Expand Down
26 changes: 26 additions & 0 deletions tests/bugs/heal/bug1330
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
puts "=========="
puts "BUG1330"
puts "=========="

# ShapeAnalysis_FreeBounds::ConnectEdgesToWires crash (Standard_OutOfRange
# NCollection_Sequence::Value) with 2 wires, the first a valid loop and
# the second a single internal-oriented edge

pload MODELING

# Create w1, a valid closed loop
polyline w1 0 0 0 1 0 0 0 1 0 0 0 0

# Create w2, a wire composd of a single *internal orientation* edge
vertex v1 0 0 0
vertex v2 2 -1 0
edge e v1 v2
orientation e I
shape w2 W
add e w2


# Invoke connectWiresToWiresImpl on the pair of wires (order matters)
# This should succeed, but instead it throws Standard_OutOfRange: NCollection_Sequence::Value
compound w1 w2 c
connectedges result c
Loading