Linlin fix bio announcement toggle and bio status filter

[linlin-husky]

This is a HotFix

Description

This PR restores the Bio Status Filter and Bio Announcement Toggle to the behaviour that ran
unchanged from 2023-07-15 until PR #5261 (merge 93cc4641a, 2026-05-25; the code change
itself is 24e1c6ba2 by Sayali, 2026-05-12), per Jae's request to trace the code back to
when it worked.

Issues Fixed:

• Bio qualification criteria were silently changed. 24e1c6ba2 replaced
  daysInTeam > 60 (tenure) with weeklySummariesCount >= 8 (weekly output). These are not
  equivalent — someone six months in the team with three summaries qualified under the old
  rule and does not under the new one. The same commit updated the test fixtures
  (daysInTeam: 70 → weeklySummariesCount: 10), so the suite stayed green and the change in
  business meaning went unnoticed. Restored to the tenure rule.

• Bio Status Filter returned the wrong people. An intermediate fix replaced the on/off
  toggle with a three-button status selector matching summary.bioPosted === selectedBioStatus
  and dropped the qualification gate entirely. Unqualified users appeared in the list, and
  selecting "Posted" listed people whose workflow was already finished — the opposite of a
  to-do list. Reverted to the on/off toggle with the qualification gate restored.

• Bio Announcement Toggle. The binary switch could not express the three bio states.
  It is now an inline three-state toggle (posted / default / requested) that saves on change.
  On a qualified user, default and requested both show the yellow banner — both mean
  "still to do" — and posted clears it.

• Yellow banner and filter did not react to a toggle. state.summaries is local
  component state, so the Redux update dispatched by toggleUserBio never reached the list.
  Only a full refetch — which fired two requests — refreshed it. Setting a user to "Posted"
  now hides the banner and drops them from the filter in the same render, with no refetch.

• Owners/Administrators saw the highlight intermittently. Two useEffects write
  permissionState on mount and only one carried the Owner/Administrator fallback for
  canSeeBioHighlight and bioEditPermission; whichever async call landed last won.
  Both now apply the same fallbacks.

Fixes:

• Fixes #[priority high] — Bio Status Filter returning unqualified users and ignoring the
  qualification criteria
• Fixes #[priority high] — Bio Announcement Toggle not reflecting state changes without a
  manual page reload

Related PRs (if any):

• Addresses the regression introduced by PR Sayali : update bio status filter criteria to use totalValidWeeklySummaries #5261 (93cc4641a, merged 2026-05-25).
• No backend change required. daysInTeam is still produced by HGNRest
  (reporthelper.weeklySummaries computes it via $dateDiff; formatSummaries passes it
  through). PR Sayali : update bio status filter criteria to use totalValidWeeklySummaries #5261 only removed the frontend references and the test fixtures.

Main changes explained:

• New src/utils/bioQualification.js — single source of truth for "is this person
  qualified for a bio": totalTangibleHrs > 80 && daysInTeam > 60 && bioPosted !== 'posted'.
  The rule previously existed in three copies with inconsistent field names
  (totalValidWeeklySummaries vs weeklySummariesCount), which is how the yellow bar and the
  filter drifted apart. Covered by src/utils/__tests__/bioQualification.test.js (7 cases
  pinning both thresholds, including one asserting that weeklySummariesCount does not
  participate).

• WeeklySummariesReport.jsx — selectedBioStatus returns to a boolean
  (false = show everyone, true = qualified only), reverting the nullable-enum experiment.
  Filter predicate now calls the shared helper. Added handleBioStatusChange to patch the
  toggled row into state.summaries in place; since that is a dependency of the filtering
  effect, the banner hides and the user leaves the filter in one render. Owner/Administrator
  permission fallbacks applied in both effects that write permissionState.

• FormattedReport.jsx — yellow banner uses the shared helper. BioSwitch no longer
  triggers a double refetch; it rolls the toggle back when the API rejects the change instead
  of leaving it on a status the server never accepted, and the duplicate success toast is
  removed (toggleUserBio already raises one). Bio editing on dev-admin protected records is
  read-only again (bioCanEdit && !cantEditJaeRelatedRecord), matching the guard already
  applied to team code and summary count.

• WeeklySummariesToggleFilter.jsx — Bio Status rendered as a single SlideToggle
  alongside Trophies and Over Hours, consistent with the other filters. Removed the
  three-button selector and its optimistic-update machinery. Tooltips now have anchor elements
  (data-for) — previously rendered but never displayed — and their ids are namespaced by
  formId to avoid collisions when several instances mount.

• SlideToggle.jsx — accepts an optional checked prop. It was uncontrolled, so its
  internal state always started false: loading a saved filter left the switch reading OFF
  while the filter was active, most visibly in FilterPreviewForm. Call sites that pass only
  onChange are unaffected.

• BioFunction.jsx — migrated to the shared helper; prop renamed
  totalValidWeeklySummaries → daysInTeam.

• TriStateToggleSwitch.jsx / .module.css — inline three-state toggle moved to CSS
  modules, with clickable hit areas for each state.

• TriStateToggleSwitch.test.jsx — 6 of 8 tests were failing on this branch. The move to
  CSS modules left the test querying raw class names (.toggle-switch, .knob), which vitest
  stubs as _<key>_<hash>, so every selector returned null. Selectors now resolve through
  the same CSS module the component imports.

• WeeklySummariesReport.module.css / .module.scss — layout for the bio toggle and the
  filter row: flexible gap spacing, compact padding, fixed min-widths removed so controls size
  naturally.

How to test:

1. git checkout linlin_bio_status_toggle_modal

2. npm install && npm start

3. Clear site data/cache, then log in as an admin user

4. Navigate to Dashboard → Weekly Summaries Report

5. Verify qualification. A user qualifies only with > 80 tangible hours,
   > 60 days in team, and a bio status that is not "Posted". Someone below either
   threshold must show no yellow banner and must not appear under the Bio Status
   filter, whatever their toggle is set to.

6. Verify the Bio Announcement toggle.

   • The toggle moves cleanly between posted (left), default (centre) and
     requested (right).
   • On a qualified user, default and requested both show the yellow banner.
   • Selecting Posted hides the banner immediately, with no page reload.
   • Records for protected accounts (Jae / dev-admin) show read-only status text instead of a
     toggle, unless you are signed in as one of the allow-listed accounts.

7. Verify the Bio Status filter.

   • Turning Bio Status ON narrows the list to qualified users only.
   • With the filter ON, setting a user to Posted removes them from the list immediately —
     no manual refresh.
   • Load a saved filter that has Bio Status enabled and confirm the switch renders ON
     (it previously showed OFF while the filter was active).

8. Verify error handling. Block PATCH /userProfile/:id/toggleBio in DevTools, then change
   a status: the toggle should snap back to its previous position rather than resting on an
   unsaved value.

9. Verify the feature in dark mode.

Screenshots or videos of changes:

Screen.Recording.2026-09-14.at.9.17.02.PM.mov

Note:

• Filter state shape: selectedBioStatus is a boolean. Note this is local component
  state (useState in WeeklySummariesReport), not Redux — it is persisted only when saved
  into a named filter. Saved filters already store it as a boolean (CreateFilterModal /
  UpdateFilterModal default it to false), so existing saved filters stay valid.

• Scope — files outside WeeklySummariesReport: the dashboard is unaffected, but two areas
  outside the component changed and are worth a look:

  • src/utils/bioQualification.js (new) — shared qualification helper, imported by
    FormattedReport, WeeklySummariesReport and BioFunction.
  • UserProfile/UserProfileEdit/ToggleSwitch/TriStateToggleSwitch.* — the inline toggle
    and its test. The component is also reached through ToggleSwitch switchType="bio", whose
    only other consumer is BioFunction (currently unreferenced), so the practical blast
    radius is the Weekly Summaries bio toggle. Other switchType variants are untouched.

• Branch kept focused: 46d0ca118 "fix: Improve PeopleReport card element distribution and
  alignment" predated the bio work and was unrelated to it, so it has been reverted here
  (78553ab64) and preserved on branch linlin_people_report_card_alignment for its own PR.
  This PR's diff is limited to bio status, the shared qualification helper, and the related
  toggle components.

• SonarQube: both findings on this PR are resolved in 8d718896a — the nested template
  literal in TriStateToggleSwitch (S4624) and the discarded exception in BioSwitch.

[netlify]

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	8d71889
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6aa95b4fa7d48700087e7639
😎 Deploy Preview	https://deploy-preview-5525--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[iAbhi001]

PR Review & Testing Summary

Tested locally on branch linlin_bio_status_toggle_modal against commit a20eb1d. Everything works as expected and aligns with the PR objectives.

Verification Details:

• Bio Announcement Modal:

• Clicking Set State opens the modal correctly with all three options (Not requested/posted, Requested, Posted).

• Selecting a state updates the user card properly (e.g., tested updating status to Requested).

• Deselection / reverting behavior works as expected.

• Bio Status Filter Buttons:

• All three filter buttons render inline on a single row with proper padding and no unwanted wrapping.

• Filtering by each status correctly narrows down the user list (e.g., selecting Requested filtered the member count accurately down to matching users).

• Clicking an active filter button deselects it and restores the complete user list.

• State persists properly across page refresh and navigation.

• UI & Theming:

• Dark mode compatibility verified; button borders, backgrounds, and hover/focus states remain readable with no text-color flashing.

LGTM! Approving.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud