Dhruv - Fix blue square related issues - #2346
Open
DeMoliT1on wants to merge 3 commits into
Open
Conversation
- Stop Blue Squares for late joiners - Close enough hours email should also remove the blue square - Add full name to Administrative Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR fixes few of the Blue Square assignment issues:
Related PRS (if any):
This is a backend only PR
Main changes explained:
userHelper.jsto update logic for new user, add full name to Administrative Details and remove blue square after close enough hours email trigger.testEmailJobs.jsscript to manually test cron job functions updated in this PR.How to test:
MISSED_BY_<15%i.e no of hours logged in previous week is 85-99% of the weekly commitment./userprofile/<target_user_id>testEmailJobs.jsscript to call theassignBlueSquareForTimeNotMetfunction. Please make sure to changeTARGET_USER_IDto the id from userporfile page ``/userprofile/<target_user_id> before calling the function.weeklyAutoReplyEmailFunctionfrom the test script with the same user id.Screenshots or videos of changes:
Blue.Square.Fix.Summary.Video.webm
Note:
Since the changes in the PR are related to cron job functions which runs weekly, the test script is the only way to test the changes. Additionally you won't be able to receive any infringement emails since those are only possible on Production.