Aditya - Job descriptions: sanitize HTML before saving - #2344
Draft
AdiDubbs wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Existing job descriptions were cleaned in the database, but
createJobandupdateJobstill accepted unsanitized HTML. New or edited postings could therefore reintroduce raw tags or unsafe markup into summaries. This stores descriptions as readable plain text at both write paths.This issue concerns Item 40.
Original task
Job descriptions — sanitize HTML before saving through both the job-creation and job-update APIs.
Open master Google Doc Item 40
Master Google Doc task entry
Related PRS (if any):
No frontend changes. The existing Collaboration summary cleanup remains unchanged.
Main changes explained:
stripHtmlutility built on the repository’s existingsanitize-htmlandcheeriodependencies.createJobandupdateJob.How to test:
jest src/controllers/jobsController.test.js src/utilities/__tests__/htmlContentSanitizer.test.js --runInBand.npm run build.Automated verification evidence:
This is a backend data-sanitization change with no standalone visual state. The live PR checks passed:
Note:
The focused controller and sanitizer suites pass 45 tests on current
development.