chore(deps): bump joi from 18.2.1 to 18.2.5 - #2338
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
Security patch for proto injection fixes. Updated package.json and package-lock.json only; yarn.lock unchanged (CI uses npm).
pixelpix13
force-pushed
the
dependabot/npm_and_yarn/joi-18.2.5
branch
from
September 11, 2026 23:34
9ae9bf2 to
c22f1e6
Compare
pixelpix13
approved these changes
Sep 11, 2026
pixelpix13
left a comment
pixelpix13
left a comment
Contributor
There was a problem hiding this comment.
Review & testing summary
Rebased this PR onto current development. Updated package.json and package-lock.json only — left yarn.lock unchanged since CI uses npm ci.
What changed
joi:^18.2.1→^18.2.5(direct dependency, patch bump within v18)- No application code changes
- Security fixes included:
- Prevent messages proto injection
- Prevent proto on renames
- Email validation
allowUnderscoreoption fix
Local testing
- Checked out rebased branch from latest
development npm ci— installed successfullynpm test— 158/158 test suites passed (2,260 tests)
CI status (after rebase)
- Lint Check — (update after push)
- Tests with 10% Coverage Enforcement — (update after push)
- SonarCloud Scan — (update after push)
Risk assessment
- Medium risk — direct dependency used widely across the codebase for request/body validation (60+ files)
- Patch update within same major version (v18); security-focused changes
- Full test suite passed locally; validation behavior should remain compatible
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps joi from 18.2.1 to 18.2.5.
Commits
58ce83e18.2.5120672dMerge pull request #3131 from Hashim1999164/fix/email-allow-underscore5bd73b8fix: allow allowUnderscore option on string().email()2b4f443Merge pull request #3138 from hapijs/fix/messages-proto-injection90d0757fix: prevent messages proto injection82ff29fMerge pull request #3136 from hapijs/chore/improve-unique-documentationad308ccchore: improve unique documentationea3e15618.2.4262c4f1Merge pull request #3134 from hapijs/fix/rename-proto162f367fix: prevent proto on renamesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.