ci: integrate gersemi to format and lint CMake files (#7346)#7663
Open
ArthPatel1502 wants to merge 1 commit into
Open
ci: integrate gersemi to format and lint CMake files (#7346)#7663ArthPatel1502 wants to merge 1 commit into
ArthPatel1502 wants to merge 1 commit into
Conversation
Member
|
Ok, nice, can you apply the changes as you mentioned you did in your verification plan? As such, we’ll see how the changes and formatting looks like |
Member
|
And possibly add our definitions if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #7346.
This PR integrates Gersemi into the project's pre-commit pipeline to automatically format and lint CMake layout files (
CMakeLists.txtand.cmakefiles).Per the maintainer discussion on the tracking issue, Gersemi was chosen over
cmake-formatbecause it is actively maintained, supports modern CMake features, and provides an official pre-commit hook interface out of the box.Changes Made
BlankSpruce/gersemi-pre-commithook repository to.pre-commit-config.yaml.Verification Plan
pre-commit cleanto clear localized hook environment definitions.pre-commit run gersemi --all-files.