gui: Actually raise GExceptions in iscatt_core#7659
Merged
Conversation
Some code in iscatt was not raising the exception it was creating.
Thus, it was not having any effect.
Here is the PR text for one of the fixes that was generated by AI. I
did the others.
General fix: when an error condition is detected, **raise** the
exception instead of just constructing it.
Best fix here: in `gui/wxpython/iscatt/iscatt_core.py`, inside
`CatRastUpdater._updateCatRast`, change line 277 from:
- `GException(_("Patching category raster conditions file failed."))`
to:
- `raise GException(_("Patching category raster conditions file
failed."))`
This preserves intended functionality (error reporting via
`GException`) while ensuring the failure is not silently ignored. No
new imports, methods, or definitions are required.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
petrasovaa
approved these changes
Jul 12, 2026
echoix
added a commit
to echoix-org/grass
that referenced
this pull request
Jul 12, 2026
* gui: Actually raise GExceptions in iscatt_core
Some code in iscatt was not raising the exception it was creating.
Thus, it was not having any effect.
Here is the PR text for one of the fixes that was generated by AI. I
did the others.
General fix: when an error condition is detected, **raise** the
exception instead of just constructing it.
Best fix here: in `gui/wxpython/iscatt/iscatt_core.py`, inside
`CatRastUpdater._updateCatRast`, change line 277 from:
- `GException(_("Patching category raster conditions file failed."))`
to:
- `raise GException(_("Patching category raster conditions file
failed."))`
This preserves intended functionality (error reporting via
`GException`) while ensuring the failure is not silently ignored. No
new imports, methods, or definitions are required.
* Apply suggestions from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some code in iscatt was not raising the exception it was creating. Thus, it was not having any effect.
Here is the PR text for one of the fixes that was generated by AI. I did the others.
General fix: when an error condition is detected, raise the exception instead of just constructing it.
Best fix here: in
gui/wxpython/iscatt/iscatt_core.py, insideCatRastUpdater._updateCatRast, change line 277 from:GException(_("Patching category raster conditions file failed."))to:raise GException(_("Patching category raster conditions file failed."))This preserves intended functionality (error reporting via
GException) while ensuring the failure is not silently ignored. No new imports, methods, or definitions are required.