Skip to content

lib/datetime: Fix reliability issues and replace non-reentrant time functions #7597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NeelGhoshal wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

lib/datetime: Fix reliability issues and replace non-reentrant time functions #7597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
762592a
Reliability: Compare member by member to check object equality, "Date…
NeelGhoshal Jan 25, 2026
bce75b4
Maintainabiliy: Replace this call to the non reentrant function "loca…
NeelGhoshal Jan 25, 2026
2338578
Maintainbility: Replace this call to the non reentrant function "gmti…
NeelGhoshal Jan 25, 2026
95f6a8c
Maintainability: Replace this call to the non reentrant function "loc…
NeelGhoshal Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/datetime/local.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@
*/
int datetime_get_local_timezone(int *minutes)
{
struct tm local_tm, gm_tm;
struct tm *local, *gm;
time_t clock;
DateTime dtl, dtg, dtdiff;

time(&clock);

local = localtime(&clock);
local = localtime_r(&clock, &local_tm);

datetime_set_type(&dtl, DATETIME_ABSOLUTE, DATETIME_YEAR, DATETIME_SECOND,
0);
Expand All @@ -46,7 +47,7 @@ int datetime_get_local_timezone(int *minutes)
datetime_set_minute(&dtl, (int)local->tm_min);
datetime_set_second(&dtl, (double)local->tm_sec);

gm = gmtime(&clock);
gm = gmtime_r(&clock, &gm_tm);

datetime_set_type(&dtg, DATETIME_ABSOLUTE, DATETIME_YEAR, DATETIME_SECOND,
0);
Expand Down Expand Up @@ -80,14 +81,15 @@ int datetime_get_local_timezone(int *minutes)
void datetime_get_local_time(DateTime *dt)
{
time_t clock;
struct tm local_tm;
struct tm *local;

/* first set dt to absolute full date */
datetime_set_type(dt, DATETIME_ABSOLUTE, DATETIME_YEAR, DATETIME_SECOND, 0);

/* get the current date/time */
time(&clock);
local = localtime(&clock);
local = localtime_r(&clock, &local_tm);

/* now put current {year,month,day,hour,minute,second} into dt */
datetime_set_year(dt, (int)local->tm_year + 1900);
Expand Down
12 changes: 10 additions & 2 deletions lib/datetime/same.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@
*/
int datetime_is_same(const DateTime *src, const DateTime *dst)
{
/* WARNING: doesn't allow for padding */
return memcmp(src, dst, sizeof(DateTime)) == 0;
/* Compare field-by-field (DateTime may contain padding) */
return src->year == dst->year &&
src->month == dst->month &&
src->day == dst->day &&
src->hour == dst->hour &&
src->minute == dst->minute &&
src->second == dst->second &&
src->usec == dst->usec &&
src->timezone == dst->timezone;

Comment on lines +24 to +32

@github-actions github-actions Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pre-commit] reported by reviewdog 🐶

Suggested change
return src->year == dst->year &&
src->month == dst->month &&
src->day == dst->day &&
src->hour == dst->hour &&
src->minute == dst->minute &&
src->second == dst->second &&
src->usec == dst->usec &&
src->timezone == dst->timezone;
return src->year == dst->year && src->month == dst->month &&
src->day == dst->day && src->hour == dst->hour &&
src->minute == dst->minute && src->second == dst->second &&
src->usec == dst->usec && src->timezone == dst->timezone;

}
Loading