Skip to content

Cleanup old Component Constructors - #627

Merged
nkoukpaizan merged 3 commits into
developfrom
lukel/component-constructor-dev
Oct 22, 2026
Merged

nkoukpaizan merged 3 commits into
developfrom
lukel/component-constructor-dev

Conversation

@lukelowry

@lukelowry lukelowry commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Every PhasorDynamics component now has a single constructor, Model(BusT* ..., const ModelDataT& data) or Model(const ModelDataT& data). This precedes removing BusT* from the constructors, which will be helpful in partitioning/hierarchy

Proposed changes

  • Remove the default, bus-only, positional-parameter, and signal-pointer constructors from 16 components.
  • Update tests to construct components from model data.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • N/A There are unit tests for the new code.
  • N/A The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • The CHANGELOG.md has been updated to reflect the changes.

Further comments

Buses keep their constructors, to keep changes low

@lukelowry
lukelowry requested a review from nkoukpaizan October 21, 2026 08:23
@lukelowry
lukelowry marked this pull request as ready for review October 21, 2026 14:34
@pelesh

pelesh commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

The documentation failure showing here is fixed in #626.

@nkoukpaizan nkoukpaizan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please rebase and add a CHANGELOG entry.

Comment thread GridKit/Model/PhasorDynamics/Branch/Branch.hpp
@lukelowry
lukelowry force-pushed the lukel/component-constructor-dev branch from 370ba38 to 28da161 Compare October 22, 2026 16:33
@lukelowry

Copy link
Copy Markdown
Collaborator Author

@nkoukpaizan thank you, all good now!

@nkoukpaizan
nkoukpaizan merged commit f3d5dd6 into develop Oct 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants