Repository navigation
Add hierarchical PhasorDynamics system model with a unit test - #620
Draft
nkoukpaizan wants to merge 5 commits into
Draft
nkoukpaizan wants to merge 5 commits into
nkoukpaizan wants to merge 5 commits into
Conversation
nkoukpaizan
requested review from
abirchfield,
lukelowry,
pelesh and
superwhiskers
October 14, 2026 15:12
…f exceptions are thrown.
nkoukpaizan
force-pushed
the
nicholson/hierarchical-system
branch
from
October 14, 2026 22:30
ccd5f58 to
f967e96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an initial implementation for a PhasorDynamics hierarchical system model.
Relates to #604
Relates to #619
The approach taken here is a nested JSON format, and the PR focuses on the system model implementation. For (more) optimal partitioning (e.g., for solvers), this requires a pre-processing step to create this structure (future work).
Proposed changes
SystemModel(const SystemModelData<RealT, IdxT>& data, const std::vector<BusT*>& external_buses)andvoid addSubsystem(SystemModel* subsystem).evaluateResidual()) gain afor (const auto& subsystem : subsystems_)to go down the hierarchy.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Draft to initiate a discussion. I have a functional
TwoAreacase using this approach.I'll update the CHANGELOG and rebase as this gets closer to ready-to-merge.
cc @Steven-Roberts @alexander-novo @abdourahmanbarry