#14797 Add support for detection of N local maximum locations in a contour map - #14798
Merged
Merged
Conversation
magnesj
force-pushed
the
contour-map-top-finder-1077
branch
from
September 28, 2026 09:11
c61e9d7 to
b629313
Compare
magnesj
marked this pull request as ready for review
September 28, 2026 09:14
kriben
reviewed
Sep 28, 2026
kriben
reviewed
Sep 28, 2026
kriben
left a comment
kriben
left a comment
Collaborator
There was a problem hiding this comment.
Review comments on the contour map top finder: 3 High, 3 Medium and 4 Low.
… maps Union-find sweep from highest to lowest value computes the prominence of each peak. Peaks are filtered on prominence and edge contact, ranked by prominence or value, and thinned by minimum distance. Flat shoulders and plateaus are rejected, and prominence is measured against the minimum of each connected data region.
Add setters for line and sphere appearance on RimPolygon. Add RimPolygonCollection::updateViewsAfterPolygonsChanged(), shared with the contour map polygon tools, and a deferred variant that is safe to call from destructors.
Each contour map projection owns a peaks collection. Computed peaks are shown in the project tree and visualized as single-point marker polygons in the global polygon collection. Markers are deleted with their peak, copied views drop peaks sharing markers with the original, and peaks are flagged as outdated when the result, time step or value filter changes.
Available from the contour map context menu for Eclipse, GeoMech and ensemble statistics contour maps.
magnesj
force-pushed
the
contour-map-top-finder-1077
branch
from
September 29, 2026 07:14
0b9d6a1 to
25de6c8
Compare
kriben
reviewed
Sep 30, 2026
- RimContourMapPeaksCollection: clamp m_peakCount to [1,20] and m_minDistance to >= 0.0 - RigContourMapPeakFinder: assert z.size() matches nx*ny before indexing in computeProminenceAndRegionSize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14797
Find the N most significant local maxima ("peaks") in a contour map and show them as markers.
RigContourMapPeakFinder: ranks peaks by prominence, enforces a minimum distance, skips edge/undefined cells. Unit tested.