#14739 Fix null pointer crash in intersection result text builders - #14740
Open
magnesj wants to merge 1 commit into
Open
#14739 Fix null pointer crash in intersection result text builders#14740magnesj wants to merge 1 commit into
magnesj wants to merge 1 commit into
Conversation
Guard against a null flatIntersectionPartMgr() in RiuResultTextBuilder and RiuFemResultTextBuilder. The part manager is only created when the display model is built, but result text can be requested (via selection updates) before that happens, e.g. right after appending a new intersection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14739
Problem
RiuResultTextBuilder::geometrySelectionText()andRiuFemResultTextBuilder::geometrySelectionText()checkedm_2dIntersectionViewfor null but calledm_2dIntersectionView->flatIntersectionPartMgr()->unflattenTransformMatrix(...)without checking thatflatIntersectionPartMgr()itself is non-null.m_flatIntersectionPartMgris only created inRim2dIntersectionView::onCreateDisplayModel(). Result text can be requested via selection-change handling right after a new intersection is appended, before the display model (and part manager) is created, causing a null pointer dereference and crash.Fix
Add a null check on
flatIntersectionPartMgr()alongside the existingm_2dIntersectionViewcheck in both result text builders.