RifReaderOpmCommon: Compute restart data size locally - #14713
Open
kriben wants to merge 1 commit into
Open
Conversation
magnesj
approved these changes
Sep 12, 2026
| std::int64_t currentReportIndex = isUnified ? -1 : 0; | ||
| for ( const auto& entry : entries ) | ||
| { | ||
| if ( std::get<0>( entry ) == "SEQNUM" ) ++currentReportIndex; |
Member
There was a problem hiding this comment.
Explain why SEQNUM has special treatment.
Collaborator
Author
There was a problem hiding this comment.
SEQNUM is special because it defines report-step boundaries in an Eclipse unified restart file (.UNRST).
A unified file is structured roughly as:
SEQNUM = report step 0
INTEHEAD
PRESSURE
...
LGR
PRESSURE
...
SEQNUM = report step 10
INTEHEAD
PRESSURE
...
Therefore, in RifReaderOpmCommon::restartDataSize():
- The presence of SEQNUM means the restart file is unified.
- Each SEQNUM starts a new report-step block.
- currentReportIndex starts at -1, because the first SEQNUM advances it to report index 0.
- The increment happens before testing the keyword, allowing SEQNUM itself to be counted as part of the report step.
- reportIndex is an ordinal index, not the report-step number. This matters because report-step numbers may be non-contiguous, such as
0, 10, 20.
A separate restart file such as .X0010 contains only one report step and normally has no SEQNUM. For that case, the entire file is
report index 0, so currentReportIndex starts at 0.
kriben
force-pushed
the
restart-file-size-util
branch
from
September 14, 2026 07:08
8dff6ab to
47dca79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.