Add --stop-on-429 flag to stop scanning when the server rate limits - #663
Open
ChrisJr404 wants to merge 2 commits into
Open
Add --stop-on-429 flag to stop scanning when the server rate limits#663ChrisJr404 wants to merge 2 commits into
ChrisJr404 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #363
Adds an opt-in
--stop-on-429flag. When it is set, gobuster stops the run as soon as one of the HTTP based modes (dir, vhost, fuzz) gets a 429 back, so you don't keep hammering a server that is already rate limiting you and risk getting the IP blocked.It is off by default so nothing changes unless you ask for it, disabled by default and enabled by a cli flag like you suggested. The first worker to see a 429 prints a short message and cancels the run, the rest wind down cleanly and you get the normal Finished output.
Added tests for both the stop path and the default keep going path, and a small note in the readme. Based off the dev branch.