erf/file: ERF META and PAD record types and extension headers - #16135
Closed
sfd wants to merge 2 commits into
Closed
erf/file: ERF META and PAD record types and extension headers#16135sfd wants to merge 2 commits into
sfd wants to merge 2 commits into
Conversation
When reading an ERF file do not trust the ERF header values. Do not use wlen to set packet length. Ticket: 8836 Read rlen bytes into MAX_PAYLOAD_SIZE buffer. Use PacketCopyData() to safely update p. Ticket: 8865
Add support for ERF record types META and PAD, plus additional ETH types. Add support for ERF extension headers. These types and extension headers were already supported by erf-source-dag. Made source-erf-file and source-erf-dag more consistent. Ticket: 8962
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16135 +/- ##
==========================================
- Coverage 83.05% 83.01% -0.05%
==========================================
Files 1004 1004
Lines 277407 277454 +47
==========================================
- Hits 230410 230335 -75
- Misses 46997 47119 +122
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
approved these changes
Aug 28, 2026
Merged
Member
|
Merged in #16141, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8962
Describe changes: