Skip to content

fw: validate scope inheritance in policies and rules v2 #16132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukashino wants to merge 2 commits into from
Closed

fw: validate scope inheritance in policies and rules v2 #16132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d60bc
fw: validate scope inheritance in policies and rules
Aug 26, 2026
f32a565
fw: allow pass as a secondary action only for accept
Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/detect-parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1822,6 +1822,10 @@ static int SigParseActionDo(const char *action_in, const int idx, const bool fw_
"rules");
return -1;
}
if (idx > 0 && (flags & ACTION_PASS) && !(*action_out & ACTION_ACCEPT)) {
Comment thread
lukashino marked this conversation as resolved.
SCLogError("'pass' is only supported as a secondary action for 'accept'");
return -1;
Comment thread
lukashino marked this conversation as resolved.
}
}

/* parse scope, if any */
Expand Down Expand Up @@ -1873,6 +1877,14 @@ static int SigParseActionDo(const char *action_in, const int idx, const bool fw_
return -1;
}
*scope_out = scope_flags;
} else if (*scope_out != 0 && (flags & ACTION_PASS)) {
/* No scope given, this action inherits the scope set by the preceding
* actions of a multi-action rule. */
if (*scope_out != ACTION_SCOPE_PACKET && *scope_out != ACTION_SCOPE_FLOW) {
SCLogError("invalid action scope '%s' in action '%s': only 'packet' and 'flow' allowed",
ActionScopeToString((enum ActionScope) * scope_out), action_in);
return -1;
}
}

/* require explicit action scope for fw rules */
Expand Down
Loading