Backport8 8678 v1 - #16119
Closed
catenacyber wants to merge 2 commits into
Closed
Conversation
added 2 commits
August 26, 2026 14:33
Ticket: 8678 In FilePruneFile() `window * 3` was computed in uint32_t arithmetic. The guard exists to ensure `file->size > window`, so on wrap around `file->size - window` underflows and content_inspected is set to a bogus value, breaking file inspection. Make window uint64_t so the multiplication cannot wrap. (cherry picked from commit f3910d5)
Ticket: 8678 With an inspect window of 0xAAAAAAAB the `window * 3` guard wrapped to 1 in uint32_t arithmetic, so it passed for a 64 byte file and content_inspected was set to `file->size - window`, an underflow. (cherry picked from commit 8e551f2)
|
AI-generated review posted automatically by Suricata ai-review. Verdict: approve No high- or medium-severity findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #16119 +/- ##
==============================================
- Coverage 81.71% 81.69% -0.02%
==============================================
Files 1016 1016
Lines 277201 277223 +22
==============================================
- Hits 226509 226477 -32
- Misses 50692 50746 +54
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
approved these changes
Aug 26, 2026
|
Information: QA ran without warnings. Pipeline = 33376 |
Member
|
Merged in #16123, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8706
Describe changes: