flow/rate: fix ring flushing - #16115
Closed
inashivb wants to merge 1 commit into
Closed
Conversation
The fn to flush the ring is supposed to flush the entire ring buffer but it only resets the buffer up to the "length" bytes. Fix this calculation to correctly reflect the number of bytes that need to be reset. Ticket: 8826
|
AI-generated review posted automatically by Suricata ai-review. Verdict: approve No high- or medium-severity findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16115 +/- ##
==========================================
- Coverage 83.06% 83.05% -0.01%
==========================================
Files 1004 1004
Lines 277376 277405 +29
==========================================
+ Hits 230389 230403 +14
- Misses 46987 47002 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
approved these changes
Aug 26, 2026
|
Information: QA ran without warnings. Pipeline = 33356 |
Merged
Member
|
Merged in #16118, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8826