mpm/ac-ks: fix integer overflow in delta table size calc - #16112
Closed
victorjulien wants to merge 1 commit into
Closed
mpm/ac-ks: fix integer overflow in delta table size calc#16112victorjulien wants to merge 1 commit into
victorjulien wants to merge 1 commit into
Conversation
In very large rulesets with lots of different patterns the size calculation could overflow. Ticket: OISF#8844.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16112 +/- ##
==========================================
- Coverage 83.06% 83.02% -0.04%
==========================================
Files 1004 1004
Lines 277376 277387 +11
==========================================
- Hits 230389 230306 -83
- Misses 46987 47081 +94
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 33351 |
victorjulien
marked this pull request as ready for review
August 26, 2026 07:04
jasonish
approved these changes
Aug 28, 2026
jasonish
left a comment
jasonish
left a comment
Member
There was a problem hiding this comment.
Agreed, no reasonable SV test.
Merged
Member
Author
|
Merged in #16141, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In very large rulesets with lots of different patterns the size calculation could overflow.
Ticket: #8844.
I didn't find a way to reach this in a SV test.