8.0.x: rust: clippy fixes - #16106
Closed
jasonish wants to merge 2 commits into
Closed
Conversation
jasonish
commented
Aug 25, 2026
jasonish
commented
Member
- rust: fix clippy warnings
- github-ci: set rust version known to 1.98.0
Fix the following lints: - clippy::box_default - clippy::byte_char_slices - clippy::collapsible_match - clippy::manual_clear - clippy::question_mark - clippy::to_string_in_format_args - clippy::useless_borrows_in_formatting - unused_imports (rustc)
The previous commit makes us clippy clean on 1.98.0.
|
AI-generated review posted automatically by Suricata ai-review. Verdict: approve No high- or medium-severity findings. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #16106 +/- ##
==============================================
- Coverage 81.69% 81.68% -0.01%
==============================================
Files 1016 1016
Lines 277166 277151 -15
==============================================
- Hits 226430 226395 -35
- Misses 50736 50756 +20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
approved these changes
Aug 25, 2026
|
Information: QA ran without warnings. Pipeline = 33331 |
Member
|
Merged in #16113, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.