next/1462/20260825/v1 - #16099
Merged
Merged
Conversation
Mapping an app-layer progress state to its generic request-/response- hook alias was hardcoded in multiple places. This commit adds a wrapper to unify it to a single function. It returns the config-form (hyphenated) name, or NULL for an intermediate state. Ticket: 8712
Every hook has a built-in default policy, but expressing anything other than the built-in meant naming each hook explicitly. This commit adds a `default-policy` setting that covers all hooks below it. For any hook the most specific setting present wins. DoParseAppSubStatePolicy() collapses into DoParseAppPolicy() as a sub state hook only differs by an extra path segment. Ticket: 8712
Validate the resolved scope against the class of hook it is being applied to and fail at startup if it does not fit. Ticket: 8712
Ticket: 8768
A rule like `frame:http1.response; to_md5;` could have a buffer bigger than the frame Ticket: 8763
Ticket: 8750
victorjulien
requested review from
a team,
jasonish and
jufajardini
as code owners
August 25, 2026 05:56
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16099 +/- ##
=======================================
Coverage 83.05% 83.06%
=======================================
Files 1004 1004
Lines 277359 277376 +17
=======================================
+ Hits 230370 230389 +19
+ Misses 46989 46987 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 33277 |
catenacyber
approved these changes
Aug 25, 2026
catenacyber
left a comment
catenacyber
left a comment
Contributor
There was a problem hiding this comment.
Good staging
Good SV
Green CI+QA
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#3312