Backport threshold 80x/v2 - #16056
Conversation
3c6bbee to
31f0e6e
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #16056 +/- ##
==============================================
- Coverage 81.69% 81.69% -0.01%
==============================================
Files 1016 1017 +1
Lines 277166 277179 +13
==============================================
+ Hits 226430 226440 +10
- Misses 50736 50739 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 33156 |
Mostly meant to help unittests and fuzz targets alloc the storage correctly. (cherry picked from commit ad1459d)
(cherry picked from commit 730ff50)
Seed value will have to be used by the caller's hash function. (cherry picked from commit b742d58)
Use for IPv6 in the main hash. Update IPv4 thread cache to also use a seed. For this the thread initialization is done at thread init instead on the first packet. The thread ctx is no longer stored in a thread_local, but instead uses the thread storage API to store in the ThreadVars. This way it will stay active during rule reloads as well. Ticket: OISF#8617. (cherry picked from commit c27868a)
(cherry picked from commit f67dadc)
Can get called multiple times in the multi-tenancy case. (cherry picked from commit cefee13)
Use new allocator to properly set up thread storage. (cherry picked from commit 9e82ff8)
31f0e6e to
d0bda57
Compare
|
Information: QA ran without warnings. Pipeline = 33215 |
| typedef struct HashTable_ { | ||
| HashTableBucket **array; | ||
| uint32_t array_size; | ||
| uint32_t seed; /**< optional random seed, to be used by the registered hash function. */ |
There was a problem hiding this comment.
Is this a breaking change ?
There was a problem hiding this comment.
This looks like a breaking change: changing a structure defined in public headers, and a structure that may be commonly used by library users/plugins.
But it looks fine thanks to padding as we are just appending in the place we had left...
There was a problem hiding this comment.
Ah that is what you meant. Ya it fills a padding hole so it should be fine.
catenacyber
left a comment
catenacyber
left a comment
There was a problem hiding this comment.
Thanks for the work,
CI : ✅
Git ID set : looks fine for me
CLA : you already contributed
Doc update : not needed
Redmine ticket : ok https://redmine.openinfosecfoundation.org/issues/8618
Tests : main PR did not have any SV, and not sure how to test this randomness consistently, so ok
Dependencies added: none
Code : good
Commits segmentation : ok cherry-picks
Commit messages : ok cherry-picks
|
Merged in #16123, thanks! |
3 participants
#16037 rebased.