Dcerpc is fragmented/v3 - #16027
Open
inashivb wants to merge 3 commits into
Open
Conversation
To allow matches with dcerpc.flags keyword later on. DCERPC/TCP exposes a u8 as PFC flags in its header however, DCERPC/UDP stores two sets of flags flags1 and flags2 in its header. Hence, the field is kept u16 to accommodate for both.
This keyword accepts a boolean value and issues a check against the header flags in a respective direction per transaction to check if the current PDU is fragmented or not. The classification criteria is very clear for UDP: flags 0x04 have to be set on the PDU explicitly marking it fragmented. The classification criteria for TCP is a bit ambiguous in the RFC but with the current implementation in Suricata only honoring the types REQUEST, BIND, ALTER_CONTEXT, following criteria is used. PFC_FIRST_FRAG && PFC_LAST_FRAG set => it's a complete PDU; unfragmented fragmented otherwise. ref: https://pubs.opengroup.org/onlinepubs/9629399/chap12.htm Feature 8736
Feature 8736
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16027 +/- ##
==========================================
- Coverage 83.04% 83.01% -0.03%
==========================================
Files 1002 1002
Lines 276722 276827 +105
==========================================
+ Hits 229794 229811 +17
- Misses 46928 47016 +88
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 32977 |
inashivb
marked this pull request as ready for review
August 14, 2026 04:58
inashivb
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
August 14, 2026 04:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #15956
Changes since v1:
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8736
SV_BRANCH=OISF/suricata-verify#3278