Skip to content

decode/ipv6: bound hop-by-hop option to the option area #15796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uwezkhan wants to merge 1 commit into from
+4 −2
Closed

decode/ipv6: bound hop-by-hop option to the option area #15796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/decode-ipv6.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,10 @@ static void DecodeIPV6ExtHdrs(ThreadVars *tv, DecodeThreadVars *dtv, Packet *p,
/* length field for each opt */
uint8_t ip6_optlen = *(ptr + 1);

/* see if the optlen from the packet fits the total optslen */
if ((offset + 1 + ip6_optlen) > optslen) {
/* see if the optlen from the packet fits the total optslen.
* the option occupies 2 header bytes (type + len) plus
* ip6_optlen data bytes, so its data must end within optslen. */
if ((offset + 2 + ip6_optlen) > optslen) {
ENGINE_SET_INVALID_EVENT(p, IPV6_EXTHDR_INVALID_OPTLEN);
break;
}
Expand Down
Loading