test(firewall): add IMAP app-layer firewall regression test - #3319
Open
yashda wants to merge 1 commit into
Open
Conversation
IMAP is detection-only in Suricata: src/app-layer-imap.c registers protocol detection patterns but no parser, transactions or progress states. A firewall rule that hooks an IMAP app-layer state therefore loads without error yet can never match, and the app-layer firewall never engages for an IMAP flow. This test loads a drop:flow rule on imap:request_started intending to block every IMAP flow and asserts the expected behaviour: - the flow is still detected as app_proto imap (control), and - the drop rule fires and blocks the flow (alert sid 2000, action blocked), - the flow is actually dropped (firewall drop_reason.rules and blocked >= 1). It fails on affected builds (reproducing the bug) and will pass once the underlying issue is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMAP is detection-only in Suricata: src/app-layer-imap.c registers protocol detection patterns but no parser, transactions or progress states. A firewall rule that hooks an IMAP app-layer state therefore loads without error yet can never match, and the app-layer firewall never engages for an IMAP flow.
This test loads a drop:flow rule on imap:request_started intending to block every IMAP flow and asserts the expected behaviour:
It fails on affected builds (reproducing the bug) and will pass once the underlying issue is fixed.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/