backport-8: tests: enable fw default policy for 8.0.7 v1 - #3317
Closed
lukashino wants to merge 1 commit into
Closed
Conversation
Ticket: 8770
There was a problem hiding this comment.
Pull request overview
This PR lowers the required Suricata minimum version for several existing firewall default-policy tests so they run starting with Suricata 8.0.7 (instead of requiring version 9), aligning test coverage with the stated 8.0.7 enablement goal.
Changes:
- Update
requires.min-versionfrom9to8.0.7across a set of firewall default-policy test cases. - No behavioral changes to test logic beyond the minimum-version gating.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/firewall/ruletype-firewall-150-default-policy-packet-hooks/test.yaml | Lowers requires.min-version to 8.0.7 so the packet-hooks default-policy test runs on 8.0.7+. |
| tests/firewall/ruletype-firewall-148-default-policy-scope-app-hook/test.yaml | Lowers requires.min-version to 8.0.7 for the app-hook scope validation test. |
| tests/firewall/ruletype-firewall-147-default-policy-scope-packet-hook/test.yaml | Lowers requires.min-version to 8.0.7 for the packet-hook scope validation test. |
| tests/firewall/ruletype-firewall-146-default-policy-tls-request-complete/test.yaml | Lowers requires.min-version to 8.0.7 for the TLS request-complete default-policy behavior test. |
| tests/firewall/ruletype-firewall-145-default-policy-per-proto/test.yaml | Lowers requires.min-version to 8.0.7 for the per-protocol default-policy test. |
| tests/firewall/ruletype-firewall-143-default-policy-app-layer/test.yaml | Lowers requires.min-version to 8.0.7 for the app-layer default-policy test. |
| tests/firewall/ruletype-firewall-142-default-policy-packet-precedence/test.yaml | Lowers requires.min-version to 8.0.7 for the packet-precedence default-policy test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lukashino
changed the title
victorjulien
approved these changes
Aug 26, 2026
Member
|
Merged in #3325, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/8770