add tls sni auto-accept-prior-hook repro bug validation - #3313
Open
yashda wants to merge 1 commit into
Open
Conversation
Add a firewall-mode test showing that the auto-accept-prior-states (`<`) notation on a catch-all accept does not cover the prior app-layer hook when a lower-SID same-hook drop rule with a matching prefilter leads the candidate list. The rules drop TLS SNI "www.google.com" (sid:200) and accept all other SNI via `accept:flow tls:<client_hello_done` (sid:201), without an explicit `accept:hook tls:client_in_progress`. The expected result is a drop by sid:200 with an alert; the actual result is a default-app-policy drop at client_in_progress with sid:200 never firing. The test asserts the expected behaviour and therefore currently fails, documenting the defect. Reuses tests/tls/tls-client-hello-frag-01.
Collaborator
|
Is there a redmine ticket that goes with this test ? A suricata PR ? |
Contributor
Author
|
Updated the description with the Redmine ticket. |
catenacyber
added
the
requires suricata fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Add a firewall-mode test showing that the auto-accept-prior-states (
<) notation on a catch-all accept does not cover the prior app-layer hook when a lower-SID same-hook drop rule with a matching prefilter leads the candidate list.The rules drop TLS SNI "www.google.com" (sid:200) and accept all other SNI via
accept:flow tls:<client_hello_done(sid:201), without an explicitaccept:hook tls:client_in_progress. The expected result is a drop by sid:200 with an alert; the actual result is a default-app-policy drop at client_in_progress with sid:200 never firing.The test asserts the expected behaviour and therefore currently fails, documenting the defect. Reuses tests/tls/tls-client-hello-frag-01.
Redmine: https://redmine.openinfosecfoundation.org/issues/8944