tests: ipv6 hop-by-hop option length past option area - #3188
Closed
uwezkhan wants to merge 1 commit into
Closed
Conversation
5 tasks
Collaborator
|
Closing as suricata PR got closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion test for OISF/suricata#15695.
The hop-by-hop option loop in
DecodeIPV6ExtHdrsgated each option on(offset + 1 + ip6_optlen) > optslen, which let an option whose data runs one byte past the option area through; the Router Alert memcpy then read one byte past the area. The fix bounds it onoffset + 2 + ip6_optlen.The pcap is an IPv6 packet (payload len 8, next header hop-by-hop) carrying an 8 byte hop-by-hop header with three Pad1 options and a Router Alert that declares 2 data bytes while only 1 fits in the 6 byte option area, so the option is rejected as
decoder.ipv6.exthdr_invalid_optlen.Branch named to match the suricata PR so the verify run is picked up.