[18.0][IMP] web_group_expand: disable buttons when they would be a no-op - #3629
Open
ninearif wants to merge 1 commit into
Open
[18.0][IMP] web_group_expand: disable buttons when they would be a no-op#3629ninearif wants to merge 1 commit into
ninearif wants to merge 1 commit into
Conversation
Disable the expand button when all groups are already expanded, and the compress button when all groups are already collapsed, so the buttons reflect whether clicking them would have any effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expand/compress buttons added by
web_group_expandare always enabled,even when clicking them would have no effect (e.g. the expand button while
every group is already expanded). This makes it hard to tell at a glance
whether there is anything left to expand or collapse.
This PR disables each button when it would be a no-op:
The state is computed in two
ListControllergetters that walk the grouplayers the same way the existing
expandAllGroups/collapseAllGroupshandlers do, and is applied with
t-att-disabledon the existing buttons,so there is no behavior change beyond the disabled state.