[IMP] web_timeline: optional dependency arrows toggle - #3621
Draft
nghorbani wants to merge 1 commit into
Draft
Conversation
Dependency arrows were always drawn when the view sets dependency_arrow, which clutters charts with many links. Add a Dependencies button to the timeline toolbar that shows/hides the arrows at runtime; they stay on by default so existing views are unchanged. Covered by QUnit tests; version bumped to 19.0.1.1.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module
web_timelineWhat
Dependency arrows are drawn whenever a timeline view sets
dependency_arrow.On charts with many links they clutter the view and there is no way to hide
them.
This adds a Dependencies toggle button to the timeline toolbar. It appears
only when
dependency_arrowis configured, is active by default (arrows shown),and hides / redraws the arrows on click. Existing views are unchanged: the
default behaviour is still "arrows shown".
Implementation
timeline_renderer.esm.js: a reactiveshowDependenciesstate(default
Boolean(dependency_arrow)) now gatesdraw_canvas();_onToggleDependenciesClicked()flips it and redraws.timeline_renderer.xml: the toolbar button, rendered viat-if="dependency_arrow".dependency_arrow; present and togglesits state when configured.
19.0.1.1.0.Notes
Marked as draft. This was developed on a Windows machine where I could not
run the module's Hoot/QUnit suite, the full pre-commit stack (prettier
@prettier/plugin-xml, eslint), oroca-gen-addon-readmelocally, soREADME.rststill needs regenerating from thereadme/fragments and CI shouldvalidate formatting and tests. Happy to push fixups once CI reports.