[19.0][IMP] mail_attach_existing_attachment_account: foldable attachment picker - #242
Open
cliffkujala wants to merge 1 commit into
Conversation
…cker Offer the invoice's attachments through the same picker the mail composer now uses: folded by default, and laid out in as many columns as the send wizard is wide enough for. An invoice that has been mailed a few times otherwise buries the wizard's buttons under a column of checkboxes.
Contributor
|
Hi @rafaelbn, @chienandalu, |
OCA-git-bot
added
series:19.0
mod:mail_attach_existing_attachment_account
Author
|
Closing along with #241, which this depends on. Will reopen once verified. |
Contributor
|
Hi @rafaelbn, @chienandalu, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Offer the invoice's attachments through the same picker the mail composer gets in #243: folded by default, and laid out in as many columns as the send wizard is wide enough for. An invoice that has been mailed a few times otherwise buries the wizard's buttons under a column of checkboxes.
The account wizard's own "Attach a file" widget is deliberately left alone; only the existing-attachment picker changes.
Depends on
#243, which adds the
attachment_checkbox_gridwidget inmail_attach_existing_attachment. This PR is a one-line widget swap on top of it.Test plan