Skip to content

[19.0][ADD] website_sale_hide_no_variant_attributes - #1283

Open
Ricardoalso wants to merge 1 commit into
OCA:19.0from
camptocamp:website_sale_hide_no_variant_attributes
Open

[19.0][ADD] website_sale_hide_no_variant_attributes#1283
Ricardoalso wants to merge 1 commit into
OCA:19.0from
camptocamp:website_sale_hide_no_variant_attributes

Conversation

@Ricardoalso

Copy link
Copy Markdown
Contributor

Exclude attributes with Variant Creation set to Never from the website variant selector and from combination-exclusion rules, so a hidden informational attribute can no longer gray out or block Add to Cart for a visible variant-defining value.

@OCA-git-bot OCA-git-bot added series:19.0 mod:website_sale_hide_no_variant_attributes Module website_sale_hide_no_variant_attributes labels Aug 10, 2026
@Ricardoalso Ricardoalso changed the title [ADD] website_sale_hide_no_variant_attributes [19.0][ADD] website_sale_hide_no_variant_attributes Aug 10, 2026
@ivantodorovich

Copy link
Copy Markdown
Contributor

On runboat, it's not possible to "Add to cart". I get the following error:

image
    Error: An error occured in the owl lifecycle (see this Error's "cause" property)
        at handleError (http://oca-e-commerce-19-0-pr1283-a564b9fb51ed.runboat.odoo-community.org/web/assets/1/c270a7c/web.assets_frontend_lazy.min.js:740:101)
        at App.handleError (http://oca-e-commerce-19-0-pr1283-a564b9fb51ed.runboat.odoo-community.org/web/assets/1/c270a7c/web.assets_frontend_lazy.min.js:1402:29)
        at ComponentNode.initiateRender (http://oca-e-commerce-19-0-pr1283-a564b9fb51ed.runboat.odoo-community.org/web/assets/1/c270a7c/web.assets_frontend_lazy.min.js:833:19)

Caused by: TypeError: exclusions[ptavId] is not iterable
    at ProductConfiguratorDialog._checkExclusions (http://oca-e-commerce-19-0-pr1283-a564b9fb51ed.runboat.odoo-community.org/web/assets/1/c270a7c/web.assets_frontend_lazy.min.js:10370:127)
    at ProductConfiguratorDialog.<anonymous> (http://oca-e-commerce-19-0-pr1283-a564b9fb51ed.runboat.odoo-community.org/web/assets/1/c270a7c/web.assets_frontend_lazy.min.js:10349:6)
    at async Promise.all (index 0)
    at async ComponentNode.initiateRender (http://oca-e-commerce-19-0-pr1283-a564b9fb51ed.runboat.odoo-community.org/web/assets/1/c270a7c/web.assets_frontend_lazy.min.js:832:36)
handleError @ web.assets_frontend_lazy.min.js:3940
(anonymous) @ web.assets_frontend_lazy.min.js:3950

@ivantodorovich

Copy link
Copy Markdown
Contributor

But besides that, the rest seems to work well 😉

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth adding a js test tour for this feature

@Ricardoalso
Ricardoalso force-pushed the website_sale_hide_no_variant_attributes branch 2 times, most recently from 8f66037 to 5f865f3 Compare August 10, 2026 13:23
Exclude attributes with Variant Creation set to Never from the
website variant selector and from combination-exclusion rules, so a
hidden informational attribute can no longer gray out or block
Add to Cart for a visible variant-defining value.
@Ricardoalso
Ricardoalso force-pushed the website_sale_hide_no_variant_attributes branch from 5f865f3 to 8aadce1 Compare August 10, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants