[19.0][ADD] website_sale_comparison_specification_variant - #1280
Open
Ricardoalso wants to merge 1 commit into
Open
[19.0][ADD] website_sale_comparison_specification_variant#1280Ricardoalso wants to merge 1 commit into
Ricardoalso wants to merge 1 commit into
Conversation
Ricardoalso
marked this pull request as draft
August 6, 2026 12:37
OCA-git-bot
added
series:19.0
mod:website_sale_comparison_specification_ex 21dd7
Ricardoalso
force-pushed
the
website_sale_comparison_specification_variant
branch
from
August 6, 2026 12:38
6b7c429 to
a046add
Compare
OCA-git-bot
added
mod:website_sale_comparison_specification_variant
Ricardoalso
force-pushed
the
website_sale_comparison_specification_variant
branch
from
August 6, 2026 13:41
a046add to
cf6f093
Compare
Ricardoalso
changed the title
Ricardoalso
force-pushed
the
website_sale_comparison_specification_variant
branch
from
August 6, 2026 14:18
cf6f093 to
5bbe7bd
Compare
Ricardoalso
marked this pull request as ready for review
August 6, 2026 14:20
This comment was marked as resolved.
This comment was marked as resolved.
Ricardoalso
marked this pull request as draft
August 6, 2026 15:19
Ricardoalso
force-pushed
the
website_sale_comparison_specification_variant
branch
from
August 7, 2026 06:46
8295772 to
f0de46e
Compare
On the eCommerce product page's "Specifications" display and on the comparison page (/shop/compare), hide non-variant-defining attribute values that are excluded for the currently selected variant combination(s), and refresh the display when the combination changes.
Ricardoalso
force-pushed
the
website_sale_comparison_specification_variant
branch
from
August 10, 2026 07:53
f0de46e to
cf272eb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Ricardoalso
marked this pull request as ready for review
August 10, 2026 07:54
ivantodorovich
approved these changes
Aug 10, 2026
ivantodorovich
left a comment
ivantodorovich
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Tested on runboat, works as expected 🚀
imlopes
approved these changes
Aug 11, 2026
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the eCommerce product page's "Specifications" display and on the comparison page (/shop/compare), hide non-variant-defining attribute values that are excluded for the currently selected variant combination(s), and refresh the display when the combination changes.