[18.0][MIG] product_alias (was shopinvader_product_alias) - #1206
Open
sebalix wants to merge 8 commits into
Open
Conversation
…d rather than active_id which can be product.product.
sebalix
force-pushed
the
18.0-mig-shopinvader_product_alias
branch
from
May 11, 2026 13:23
b6b0431 to
ecc80e5
Compare
sebalix
marked this pull request as ready for review
May 11, 2026 13:33
paradoxxxzero
approved these changes
Jun 16, 2026
paradoxxxzero
left a comment
paradoxxxzero
left a comment
There was a problem hiding this comment.
LGTM (code & functional review)
simahawk
reviewed
Jun 17, 2026
| @@ -0,0 +1,2 @@ | |||
| This module allows to add url aliases from the product template for each | |||
Contributor
There was a problem hiding this comment.
URL? I see no URL feature here 🤔
Contributor
There was a problem hiding this comment.
Also, how is this different from having product links of type "alias"?
metaminux
suggested changes
Jul 29, 2026
metaminux
approved these changes
Aug 3, 2026
metaminux
left a comment
metaminux
left a comment
There was a problem hiding this comment.
Only one typo in DESCRIPTION.md, but LGTM
Contributor
|
This PR has the |
sebalix
force-pushed
the
18.0-mig-shopinvader_product_alias
branch
from
August 4, 2026 06:28
4916ac7 to
7d2c27c
Compare
|
Hello @simahawk Can you review that PR again ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
shopinvader_product_alias(which was hosted in a PR on shopinvader/odoo-shopinvader) to 18.0 and rename itproduct_aliasas it doesn't depend at all on Shopinvader.