Skip to content

[19.0][OU-ADD] pos_self_order: Migration scripts - #5868

Open
BhaveshHeliconia wants to merge 2 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-pos_self_order
Open

[19.0][OU-ADD] pos_self_order: Migration scripts#5868
BhaveshHeliconia wants to merge 2 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-pos_self_order

Conversation

@BhaveshHeliconia

Copy link
Copy Markdown
Contributor

No description provided.

@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:19.0 labels Jul 31, 2026
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 19.0-mig-pos_self_order branch from 2445f77 to e777210 Compare July 31, 2026 09:33
# NOTHING TO DO

pos_self_order / pos.config / self_ordering_takeaway (boolean): DEL
# DONE: preserved in pre-migration.py and used in post-migration.py to conditionally link takeout preset.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why you need to copy this, you can just keep the original name

"""
Link default presets to existing POS configurations
based on legacy self_ordering_takeaway setting.
"""

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of this should go to the migration script of pos_restaurant

@hbrunn

hbrunn commented Aug 4, 2026

Copy link
Copy Markdown
Member

/ocabot migration pos_self_order
/ocabot migration pos_restaurant

Depends on :

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Aug 4, 2026
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 19.0-mig-pos_self_order branch from e777210 to 84c2cd4 Compare August 4, 2026 10:27
@BhaveshHeliconia
BhaveshHeliconia force-pushed the 19.0-mig-pos_self_order branch from 84c2cd4 to 5276115 Compare August 4, 2026 10:31
@BhaveshHeliconia

Copy link
Copy Markdown
Contributor Author

@hbrunn Thanks for the review!

I have addressed both comments. I removed the unnecessary pre-migration.py from pos_self_order and kept the original self_ordering_takeaway column name for the post-migration.

I also moved the preset linking logic to pos_restaurant, where pos.preset is defined. I have kept the pos_restaurant changes in a separate commit within this PR.

I also tested the migration with different POS configurations and verified that the presets and fiscal positions are correctly assigned.

Please let me know if you would prefer the pos_restaurant changes to be moved to a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants