Update ember-source tarball to all-optimizations+60f0fc94 + pnpm-patch _backburner consumers - #2213
Merged
NullVoxPopuli merged 2 commits intoAug 9, 2026
Conversation
The previous tarball (+5916d3e8) broke the build and lints: - @ember/runloop stopped exporting _backburner, which ember-qunit and @ember/test-helpers import, so the repl app's bundle failed to resolve and the ssg prerender crashed on the missing dist. - The Deferred interface that replaced RSVP's in @ember/application used property-syntax resolve/reject (strictly contravariant), making App.create() unassignable to setApplication() in the tutorial app's type check. The new tarball restores the _backburner stub (wired to real pending-render state so settled() still waits), drains scheduled destroys synchronously on instance destroy (the ssg worker wipes the document right after destroy() returns), and resolves renderSettled() via a scheduler flush like classic did. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
Contributor
Footnotes
|
…rner The tarball moves to all-optimizations+60f0fc94, which drops the _backburner compat stub entirely: backburner is gone from the framework, not impersonated. The consumers that imported it are patched via pnpm patchedDependencies: - @ember/test-helpers: getSettledState reads the new isRenderPending() from @ember/renderer (the synchronous probe its TODO always asked for, covering pending flushes and pending destroy drains); the backburner timer/instance/debug-info reads collapse to their truthful constants. - ember-qunit: drops the _backburner.DEBUG toggle from setupTestIsolationValidation (there is no backburner debug info). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NullVoxPopuli-ai-agent
changed the title
Contributor
Author
|
Updated per the no-backburner-at-all direction: the tarball moves to
Full matrix re-verified locally: builds, 63 lint tasks, chrome/node suites all pass. Fresh bench numbers in NullVoxPopuli/rere-benchmark#108 — the fixes stay perf-neutral vs the pre-fix spike. |
NullVoxPopuli
merged commit Aug 9, 2026
ee7b116
into
NullVoxPopuli:test-ember-source/all-optimizations
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #2212's branch with the tarball rebuilt from the fixed
all-optimizationsbranch (emberjs/ember.js#21520, commitsa967e87..7077507) — see #2212 (comment) for the breakdown of the three ember-side fixes (_backburnercompat stub,Deferredvariance, synchronous destroy drain + flush-resolvedrenderSettled).Against this tarball, locally: build:prod, build:test, all 63 lint tasks, and chrome/node/firefox suites pass, matching the stock-ember baseline.
🤖 Generated with Claude Code