Skip to content

fix(utils): handle None values safely in MemoryTrackerDataPoint properties #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yappermoar-boop wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(utils): handle None values safely in MemoryTrackerDataPoint properties #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion nemo_rl/utils/memory_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,14 @@ class MemoryTrackerDataPoint(BaseModel):

@property
def mem_used_diff_gb(self) -> float:
if self.memory_used_after_stage_gb is None:
return 0.0
return self.memory_used_after_stage_gb - self.memory_used_before_stage_gb

@property
def new_variables(self) -> List[str]:
if self.variables_after_stage is None:
return []
return [
v
for v in self.variables_after_stage
Expand All @@ -41,9 +45,14 @@ def new_variables(self) -> List[str]:

def get_snapshot_str(self) -> str:
ray_memory_summary = memory_summary(stats_only=True, num_entries=5)
mem_after_str = (
f"{self.memory_used_after_stage_gb:>7.2f}"
if self.memory_used_after_stage_gb is not None
else " N/A"
)
return f"""💭 Driver CPU memory tracker for {self.stage}:
- Mem usage before {self.memory_used_before_stage_gb:>7.2f} GB
- Mem usage after {self.memory_used_after_stage_gb:>7.2f} GB
- Mem usage after {mem_after_str} GB
- Mem usage diff (after - before) {self.mem_used_diff_gb:>+7.2f} GB
- New variables: {self.new_variables}

Expand Down
Loading