Skip to content

Add implementation plans from the September repository review - #306

Merged
Greaker merged 1 commit into
developmentfrom
feature/review-implementation-plans
Oct 2, 2026
Merged

Greaker merged 1 commit into
developmentfrom
feature/review-implementation-plans

Conversation

@Greaker

@Greaker Greaker commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Six new plan folders under docs/plans/ (intent, design, plan, progress each), grounded in a review of the current development branch; all are Proposed and listed in docs/DOCUMENTATION_INDEX.md:
    • bond-coupon-maturity-correctness: per-holding coupon rounding, RATE-auction gating after a cancel, matured partitions closed to new issuance, the BUYBACK cancel revert, bond transfer eligibility.
    • ingestion-projection-correctness: abortable ingestion loop that closes its connection, chain-ordered log application, idempotent bond state, newest-first history, finalisation that tolerates invalid bids.
    • nb-bond-api-hardening: per-signer nonces, one RFC 7807 error handler, liveness probe and chart defaults, scoped runtime image, cleanup.
    • nb-ui-correctness-and-hardening: router and error boundaries, one 401 path, matured KPI, live coupon preview, bidder soft delete, history card, nginx headers, dead-code removal.
    • sandbox-scripts-and-ci-hardening: flag precedence, failing readiness timeouts, command validation, bid-tool install, loopback ports, image pins, pin-drift check, CI gaps.
    • documentation-refresh: neutral deployment wording, plan-tree housekeeping, removed behaviour still documented, known issues, NatSpec source links, licence inventory.
  • Four progress.md files note what changed on development after planning (Tbd: bind cctFrom to the payer and remove the unused nomination path #300–Operator-only issuer actions with route-level authorization tests #305) and which steps that makes moot.
  • Documentation only; each plan lists the operator decisions it needs before implementation.

Test plan

  • python3 scripts/verification/check-public-repo-hygiene.py
  • python3 scripts/verification/check-markdown-links.py

Six plan folders under docs/plans/, each with intent, design, plan, and
progress files, grounded in a review of the current development branch:

- bond-coupon-maturity-correctness: per-holding coupon rounding, RATE
  auction gating after a cancel, matured partitions closed to new
  issuance, the BUYBACK cancel revert, and bond transfer eligibility.
- ingestion-projection-correctness: abortable ingestion loop that closes
  its connection, chain-ordered log application, idempotent bond state,
  newest-first history, and finalisation that tolerates invalid bids.
- nb-bond-api-hardening: per-signer nonces, one RFC 7807 error handler,
  liveness probe and chart defaults, scoped runtime image, cleanup.
- nb-ui-correctness-and-hardening: router and error boundaries, one 401
  path, matured KPI, live coupon preview, bidder soft delete, history
  card, nginx headers, dead-code removal.
- sandbox-scripts-and-ci-hardening: flag precedence, failing readiness
  timeouts, command validation, bid-tool install, loopback ports, image
  pins, pin-drift check, CI gaps.
- documentation-refresh: neutral deployment wording, plan-tree
  housekeeping, removed behaviour still documented, known issues,
  NatSpec source links, licence inventory.

All plans are Proposed; the documentation index lists them. Four progress
files note what changed on development after planning (#300 to #305)
and which plan steps that makes moot.
@Greaker
Greaker merged commit 00920ea into development Oct 2, 2026
6 checks passed
@Greaker
Greaker deleted the feature/review-implementation-plans branch October 2, 2026 08:53
@Greaker Greaker mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant