Repository navigation
openmvs: cite the merged upstream fix for the CUDA error patch - #582875
Conversation
The vendored patch cited cdcseacave/openMVS#1316, which was closed in favour of NixOS#1324. NixOS#1324 fixes the uninitialized error strings as part of a larger rework (e0ef7ee96f) that does not apply to 2.4.0, so the patch stays until the next release. Assisted-by: Claude Code (Claude Opus 5.5)
MiniHarinn
left a comment
There was a problem hiding this comment.
I would recommend stopping vendoring the patch and using fetchpatch instead, since the commit is merged upstream and is self-explanatory.
|
@MiniHarinn upstream's change is a rework, not merging the patch. It doesn't apply cleanly. I was also unable to filter it so it would apply cleanly. The vendored copy is the smallest difference we can maintain unless we want to bump to a commit including the rework instead of sticking to a release. If you find it's self-explanatory and there's no ambiguity that the patch should be removed when updating, I'm happy to close this! |
MiniHarinn
left a comment
There was a problem hiding this comment.
I wouldn't mind having a commit temporary cited here, it will eventually get removed in the next update anyway. LGTM
The vendored
report-cuda-error-uninit.patchcited cdcseacave/openMVS#1316, which upstream closed in favour of cdcseacave/openMVS#1324 (merged). #1324 fixes the uninitialized CUDA error strings as part of a larger rework, e0ef7ee96f, which does not apply to 2.4.0 (git apply --checkfails on all 11 files). So the patch stays, and the comment now cites the merged fix and says to remove the patch on the next release.Comment-only change: no rebuilds.
AI disclosure: prepared by Claude Code (Claude Opus 5.5) at the author's request.
./result/bin/.nixpkgs-reviewon this PR. See nixpkgs-review usage.passthru.tests.🤖 Generated with Claude Code