Skip to content

stardust-xr-*: <many> -> 0.51.1 & various improvements - #457027

Merged
Scrumplex merged 14 commits into
NixOS:masterfrom
Pandapip1:stardust-xr-major-stuff
Jul 18, 2026
Merged

stardust-xr-*: <many> -> 0.51.1 & various improvements#457027
Scrumplex merged 14 commits into
NixOS:masterfrom
Pandapip1:stardust-xr-major-stuff

Conversation

@Pandapip1

@Pandapip1 Pandapip1 commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

"Just" a "small" update/testing PR.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 changed the title stardust-xr-*: add tests; stardust-xr-server: 0.44.1 -> 0.45.1 stardust-xr-*: add tests and cleanup; stardust-xr-server: 0.44.1 -> 0.45.1 Oct 30, 2025
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch from 6df0683 to 0e4f097 Compare November 7, 2025 03:18
@Pandapip1 Pandapip1 mentioned this pull request Nov 7, 2025
Closed
13 tasks
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch 4 times, most recently from 0b9b888 to 4fa0b28 Compare November 7, 2025 10:10
This was referenced Dec 5, 2025
Open
Open
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 13, 2025
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch 2 times, most recently from c6d834c to 9274b00 Compare December 15, 2025 18:56
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 15, 2025
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch from 9274b00 to 62246a6 Compare December 15, 2025 18:59
@Pandapip1 Pandapip1 mentioned this pull request Dec 20, 2025
Draft
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 23, 2025
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2026
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch from 38c32ea to e8c0bb4 Compare July 4, 2026 17:58
@nixpkgs-ci nixpkgs-ci Bot removed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Jul 4, 2026
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch 8 times, most recently from 49c9273 to db3704a Compare July 5, 2026 03:34
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch from 7d52917 to 1f1fd4f Compare July 5, 2026 03:41
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch 3 times, most recently from 1ef888d to d2cc1f7 Compare July 5, 2026 18:19
@Pandapip1
Pandapip1 force-pushed the stardust-xr-major-stuff branch from d2cc1f7 to 020d438 Compare July 5, 2026 18:22
@Scrumplex

Scrumplex commented Jul 5, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457027 --additional-package nixosTests.stardust-xr-atmosphere --additional-package nixosTests.monado --additional-package nixosTests.stardust-xr-flatland
Commit: 5f03ac620b2c54eb22a450b59cde44096afc9c7f

x86_64-linux

✅ 3 tests built:
  • nixosTests.monado
  • nixosTests.stardust-xr-atmosphere
  • nixosTests.stardust-xr-flatland
✅ 7 packages built:
  • stardust-xr-atmosphere
  • stardust-xr-flatland
  • stardust-xr-gravity
  • stardust-xr-non-spatial-input
  • stardust-xr-protostar
  • stardust-xr-server
  • tests.lib-tests

@Pandapip1

Pandapip1 commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@Scrumplex would you mind re-reviewing? The main changes are that I made a minimal wayland client, packaged it, and used that in test, and also added a patch to the stardust server where it made some incorrect assumptions. There's also the various minor fixes.

@Scrumplex

Scrumplex commented Jul 6, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457027 --additional-package nixosTests.stardust-xr-atmosphere --additional-package nixosTests.monado --additional-package nixosTests.stardust-xr-flatland
Commit: 020d4389018295feed4b3c27ef2fc0e436f8f80d

x86_64-linux

✅ 3 tests built:
  • nixosTests.monado
  • nixosTests.stardust-xr-atmosphere
  • nixosTests.stardust-xr-flatland
✅ 8 packages built:
  • stardust-xr-atmosphere
  • stardust-xr-flatland
  • stardust-xr-gravity
  • stardust-xr-non-spatial-input
  • stardust-xr-protostar
  • stardust-xr-server
  • tests.lib-tests
  • wayland-colorbar

@Pandapip1

Pandapip1 commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

I moreso meant the diff itself, sorry.

@nixos-discourse

nixos-discourse commented Jul 8, 2026

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/7202

Scrumplex
Scrumplex approved these changes Jul 12, 2026
View reviewed changes

@Scrumplex Scrumplex left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 12, 2026
@nixos-discourse

nixos-discourse commented Jul 13, 2026

Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/3161

@Pandapip1

Pandapip1 commented Jul 16, 2026

Copy link
Copy Markdown
Member Author

Bump; would really appreciate this to be merged!

@Pandapip1

Pandapip1 commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Sorry to continually bump this, but I'd really like to get this PR in particular merged as soon as possible!

EDIT: To be clear, this is because this is already seriously out of date and the server takes ages to compile.

@Scrumplex
Scrumplex added this pull request to the merge queue Jul 18, 2026
@Scrumplex Scrumplex added the backport release-26.05 Backport PR automatically label Jul 18, 2026
Merged via the queue into NixOS:master with commit d46ba76 Jul 18, 2026
30 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-26.05:

@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jul 18, 2026
Merged
@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jul 18, 2026
@Pandapip1
Pandapip1 deleted the stardust-xr-major-stuff branch July 18, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes
@technobaboo technobaboo Awaiting requested review from technobaboo

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: teams Relating to team creation, updates, other management actions 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. backport release-26.05 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pandapip1 @Scrumplex @nixos-discourse