chore: remove unused CSRF token from server switcher - #17
Merged
Merged
Conversation
The token generated in header.php's changeServ handler was never validated server-side (pages/server.php never read csrf_token, and never has since the token was introduced) - it was pure client-side theater with no real protection. The endpoint is also read-only (lists demo files) with no session/auth to protect, so there's nothing meaningful for CSRF to target here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
csrf_tokenfrom the AJAX request inheader.php's server switcher.pages/server.phpnever reads$_POST['csrf_token'], and has never done so since the token was introduced (checked full git history) - pure theater, no real protection.No behavior change for users.
Test plan
vendor/bin/phpunit- 25 tests, OKvendor/bin/phpstan analyse- no errorsvendor/bin/phpcs- clean on changed file